Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHES support #291

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Add GHES support #291

merged 6 commits into from
Jan 10, 2023

Conversation

sorekz
Copy link
Contributor

@sorekz sorekz commented Jan 9, 2023

Hi,
I'd like to use this action on a GHES (Github Enterprise Server). For that all references to github.com need to be replaced to the actual servers hostname. On the runners the environment variables contain the correct hostname.

I went over the code and removed all hardcoded references to github.com and the octokit baseUrl. Would be awesome if that can be integrated into your action.

Currently not tested as I'm facing the same issues as in #289 but I'll do so of course as soon as it works again.

@BetaHuhn
Copy link
Owner

BetaHuhn commented Jan 9, 2023

Thanks for the PR @sorekz!

#289 should be fixed now. If you test that everything works and mark the PR as ready for review I'd be happy to merge it.

@sorekz
Copy link
Contributor Author

sorekz commented Jan 10, 2023

Done.
I can't test all features of the action on the GHES because I don't have a setup for all scenarios but I'm confident.

@sorekz sorekz marked this pull request as ready for review January 10, 2023 08:38
Copy link
Owner

@BetaHuhn BetaHuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BetaHuhn BetaHuhn merged commit 5c87303 into BetaHuhn:master Jan 10, 2023
@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants